This repository was archived by the owner on Feb 14, 2019. It is now read-only.
Fix resetting of viewDate #619
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esetting the viewDate, this will prevent to reset the view of the month if the view already moved away from the current selected date.
Collaborator
|
Please fix the tests before we can merge this. |
…e` call within `setDatesDisabled` otherwise it will reset the `viewDate` (aka issue smalot#617)
Author
|
@AuspeXeu here is a refactored fix for the issue #617 my previous "solution" had the side effect of preventing the date to be updated by code, that's why the tests were failing. This solution makes the tests pass without problem, I'm also adding a new test specifically for the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
updatemethod will compareviewDateinstead ofdateto correctly reset(or not) theviewDateattribute,viewDatewill reset todateon thehidemethod. Fixes #617